Use NodePath in LinkableDictionary #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 465bc04 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
This was referenced Oct 31, 2024
lorisleiva
force-pushed
the
loris/node-path-and-heap
branch
from
46bf57a to
282dd13
Compare
lorisleiva
force-pushed
the
loris/use-node-path-in-linkables
branch
from
62fbc94 to
77fa128
Compare
Merged
Member
Author
lorisleiva
changed the base branch from
loris/node-path-and-heap
to
graphite-base/270
lorisleiva
force-pushed
the
loris/use-node-path-in-linkables
branch
from
77fa128 to
465bc04
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR records and resolves
NodePathsinstead ofNodesinLinkableDictionaries. This means, we can now access the whole path from the nodes we resolve and, therefore, push that path within our currentNodeStack.